Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: potential fix for #480 #486

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

WIP: potential fix for #480 #486

wants to merge 1 commit into from

Conversation

zbjornson
Copy link
Collaborator

@zbjornson zbjornson commented Jan 1, 2022

@sky-nunomarcos can you give this branch a try and see if it resolves the performance issue you see?

Am I correct in assuming that you're using Summaries? Are you setting maxAgeSeconds and ageBuckets?


It sounds like maxAgeSeconds and ageBuckets should be set normally. They weren't set when they were added to prom-client to avoid a breaking change. I don't think the rotation interval has to be exact though, so we can batch rotations up at least.

@github-actions
Copy link

github-actions bot commented Jan 1, 2022

Thanks for opening this pull request! Each pull request require an update in the CHANGELOG. Please update it based on your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant