Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release - Run golangci-lint and govulncheck in CI workflow #81

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Conversation

briskt
Copy link
Contributor

@briskt briskt commented Nov 12, 2024

ITSE-921 use gosec and/or govulncheck in all Go apps

Rather than fix all of the lint issues immediately, I commented those checks in the configuration file. The next series of PRs will include solutions for the issues.

@briskt briskt requested a review from a team as a code owner November 12, 2024 05:13
@briskt briskt requested review from a team, jason-jackson and hobbitronics and removed request for a team November 12, 2024 05:14
Copy link

Copy link

@hobbitronics hobbitronics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just wondering what .golangci.yaml is used by. golanc-lin-action?

@briskt
Copy link
Contributor Author

briskt commented Nov 12, 2024

Looks good. Just wondering what .golangci.yaml is used by. golanc-lin-action?

Yes, golangci-lint uses it.

@briskt briskt merged commit d5c5e3b into develop Nov 12, 2024
6 checks passed
@briskt briskt deleted the lint branch November 12, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants