-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deepfactor #237
deepfactor #237
Conversation
I moved storybook back out of dependencies, as it did this when installing in a consumer app, which I didn't want. `mike@Michaels-Mac-mini cover-ui % npm i -D https://github.com/silinternational/ui-components#12ab2480b951fa5e324cf5f1c84209694279b9e1 added 1287 packages, removed 1 package, changed 5 packages, and audited 1840 packages in 1m` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this is fine, though I don't fully know the effects of things like removing sass-loader or svelte-loader.
These are webpack build tools we never used (probably mistakenly brought in for storybook config). Storybook build still works so shouldn't be a problem. |
🎉 This PR is included in version 10.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Added
Changed
Removed