Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add(SearchableSelect): add clear button to SearchableSelect #288

Merged
merged 3 commits into from
Oct 3, 2024
Merged

add(SearchableSelect): add clear button to SearchableSelect #288

merged 3 commits into from
Oct 3, 2024

Conversation

hobbitronics
Copy link
Contributor

@hobbitronics hobbitronics commented Sep 25, 2024 •
edited
Loading

Added

  • add clear button to SearchableSelect

Feature branch checklist

  • Documentation (README, etc.)
  • Run make format, make dry and make install

@hobbitronics hobbitronics requested review from a team, briskt, forevermatt, mtompset and jason-jackson and removed request for a team September 25, 2024 05:30
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

forevermatt
forevermatt approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@forevermatt forevermatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming the timing issue I asked about isn't actually a problem. 👍

components/custom/SearchableSelect/SearchableSelect.svelte Show resolved Hide resolved
@hobbitronics hobbitronics merged commit b865d73 into develop Oct 3, 2024
3 checks passed
@hobbitronics hobbitronics deleted the add-clear-button branch October 3, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@forevermatt forevermatt forevermatt approved these changes

@briskt briskt Awaiting requested review from briskt briskt is a code owner automatically assigned from silinternational/js-devs

@mtompset mtompset Awaiting requested review from mtompset mtompset is a code owner automatically assigned from silinternational/js-devs

@jason-jackson jason-jackson Awaiting requested review from jason-jackson jason-jackson is a code owner automatically assigned from silinternational/js-devs

@devon-sil devon-sil Awaiting requested review from devon-sil

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hobbitronics @forevermatt