Skip to content

Commit

Permalink
Revert aws-login change (part2)
Browse files Browse the repository at this point in the history
  • Loading branch information
imnasnainaec committed Oct 18, 2024
1 parent d64f001 commit 13d2fa6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion deploy/helm/aws-login/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ awsEcr:
imageTag: "0.3.0"
jobName: ecr-cred-helper
schedule: "0 */8 * * *"
secretsName: aws-login-credentials
secretsName: aws-ecr-credentials
serviceAccount: account-ecr-login
role: role-ecr-login
roleBinding: role-ecr-login-binding
8 changes: 4 additions & 4 deletions docs/deploy/kubernetes_design/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,10 @@ The following diagram shows the Kubernetes resources used to create the image pu

### Additional AWS Login Resources

| Resource | Kind | Description |
| --------------------- | --------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| aws-ecr-config | ConfigMap | `aws-ecr-config` defines the runtime configuration for AWS ECR logins. |
| aws-login-credentials | Secret | `aws-login-credentials` defines the access accounts and credentials to log in to the AWS ECR service. Note that these credentials may be different than the `aws-s3-credentials` |
| Resource | Kind | Description |
| ------------------- | --------- | --------------------------------------------------------------------------------------------------------------------------------------------- |
| aws-ecr-config | ConfigMap | Defines the runtime configuration for AWS ECR logins. |
| aws-ecr-credentials | Secret | Defines the access accounts and credentials to log in to the AWS ECR service. Note that these may be different than the `aws-s3-credentials`. |

## SSL Termination

Expand Down

0 comments on commit 13d2fa6

Please sign in to comment.