.59 method coverage

sillsdev · Oct 11, 2024 · 5e70834 · 5e70834
1 parent 3da4411
commit 5e70834
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 17 deletions.
diff --git a/Backend.Tests/Otel/OtelServiceTests.cs b/Backend.Tests/Otel/OtelServiceTests.cs
@@ -1,5 +1,6 @@
 // using System.Diagnostics;
 using System;
+using System.Diagnostics;
 using BackendFramework.Otel;
 using Microsoft.Extensions.DependencyInjection;
 using NUnit.Framework;
@@ -9,23 +10,12 @@ namespace Backend.Tests.Otel
     public class OtelServiceTests
     {
 
-        [Test]
-        public static void TestAddOtelTagCoverage()
-        {
-            var services = new ServiceCollection();
-            OtelService.AddOtelInstrumentation(services);
-            OtelService.AddOtelTag("test key", "test val");
-
-
-        }
-
         // [Test]
         // public static void TestAddOtelTagCoverage()
         // {
         //     var services = new ServiceCollection();
         //     OtelService.AddOtelInstrumentation(services);
-        //     Activity? act = OtelService.AddOtelTag("test key", "test val");
-        //     Assert.That(act, Is.Not.Null);
+        //     OtelService.AddOtelTag("test key", "test val");
 
 
         // }
@@ -36,6 +26,9 @@ public static void TestAddOtelTag()
         {
             var services = new ServiceCollection();
             OtelService.AddOtelInstrumentation(services);
+
+            // AddActivityListener();
+
             var activity = OtelService.AddOtelTag("test key", "test val");
             Console.WriteLine("result was " + activity);
             Assert.That(activity, Is.Not.Null);
@@ -57,5 +50,17 @@ public static void TestAddOtelTag()
 
         }
 
+        private static void AddActivityListener()
+        {
+            var activityListener = new ActivityListener
+            {
+                ShouldListenTo = s => true,
+                SampleUsingParentId = (ref ActivityCreationOptions<string> activityOptions) => ActivitySamplingResult.AllData,
+                Sample = (ref ActivityCreationOptions<ActivityContext> activityOptions) => ActivitySamplingResult.AllData
+            };
+            ActivitySource.AddActivityListener(activityListener);
+
+        }
+
     }
 }
diff --git a/Backend/Otel/OtelService.cs b/Backend/Otel/OtelService.cs
@@ -44,9 +44,4 @@ public static void AddOtelInstrumentation(IServiceCollection services)
         services.AddOpenTelemetryInstrumentation();
     }
 
-    public static Activity? GetActivity()
-    {
-        return Activity.Current;
-
-    }
 }