Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a commit message checker. #3019

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

jasonleenaylor
Copy link
Contributor

@jasonleenaylor jasonleenaylor commented Mar 28, 2024

with multiple
issues in the initial commit comment to see if it is working or not when we call the fieldworks job


This change is Reviewable

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.47%. Comparing base (18c44cd) to head (9696c11).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3019   +/-   ##
=======================================
  Coverage   73.47%   73.47%           
=======================================
  Files         265      266    +1     
  Lines       10298    10300    +2     
  Branches     1212     1212           
=======================================
+ Hits         7566     7568    +2     
  Misses       2378     2378           
  Partials      354      354           
Flag Coverage Δ
backend 82.92% <ø> (ø)
frontend 64.70% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

* This lints all the commit comments in a PR and reports on any that
  do not match the linting rules
* It adds a pretty comment to the PR if there are any issues found
@jasonleenaylor jasonleenaylor marked this pull request as ready for review April 2, 2024 18:47
Copy link
Collaborator

@imnasnainaec imnasnainaec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jasonleenaylor)

@jasonleenaylor jasonleenaylor merged commit 14d29bc into master Apr 3, 2024
18 checks passed
@jasonleenaylor jasonleenaylor deleted the feature/addCommitChecker branch April 3, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants