Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace backend formatter and license reporter #3389

Merged
merged 11 commits into from
Oct 7, 2024
Merged

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 2, 2024

Resolves #3354


This change is Reviewable

@imnasnainaec imnasnainaec added maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. .NET Pull requests that update .net code labels Oct 2, 2024
@imnasnainaec imnasnainaec self-assigned this Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.68%. Comparing base (f36a699) to head (328dd8c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3389      +/-   ##
==========================================
- Coverage   74.71%   74.68%   -0.04%     
==========================================
  Files         280      280              
  Lines       10838    10838              
  Branches     1314     1314              
==========================================
- Hits         8098     8094       -4     
- Misses       2370     2373       +3     
- Partials      370      371       +1     
Flag Coverage Δ
backend 83.84% <ø> (-0.08%) ⬇️
frontend 66.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review October 3, 2024 15:19
@imnasnainaec imnasnainaec added the documentation Improvements or additions to documentation label Oct 3, 2024
@imnasnainaec imnasnainaec changed the title Replace backend license report generator Replace backend formatter and license report generator Oct 3, 2024
@imnasnainaec imnasnainaec changed the title Replace backend formatter and license report generator Replace backend formatter and license reporter Oct 3, 2024
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit a78e50e into master Oct 7, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the nuget-license branch October 7, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend documentation Improvements or additions to documentation maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet tools used by The Combine are deprecated/obsolete
2 participants