Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[deploy] Fix helm config and maintenance scripts #3404

Merged
merged 14 commits into from
Oct 21, 2024
Merged

[deploy] Fix helm config and maintenance scripts #3404

merged 14 commits into from
Oct 21, 2024

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Oct 17, 2024

  • Updates deploy_qa.yml workflow's step for removing old images
  • Restores pullSecretName in deploy/helm/thecombine/values.yaml
  • Removes one-shot maintenance script db_update_audio_type.py
  • Restores python3 shebang in maintenance scripts
  • Updates kubernetes documentation, including prep for OpenTelemetry

This change is Reviewable

@imnasnainaec imnasnainaec added bug Something isn't working deployment maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. kubernetes labels Oct 17, 2024
@imnasnainaec imnasnainaec self-assigned this Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.66%. Comparing base (6a9de6e) to head (3fae27e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3404   +/-   ##
=======================================
  Coverage   74.66%   74.66%           
=======================================
  Files         280      280           
  Lines       10856    10856           
  Branches     1317     1317           
=======================================
  Hits         8106     8106           
  Misses       2377     2377           
  Partials      373      373           
Flag Coverage Δ
backend 83.84% <ø> (ø)
frontend 66.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as draft October 18, 2024 11:44
@imnasnainaec imnasnainaec changed the title [deploy] Fix helm config [deploy] Fix helm config and maintenance scripts Oct 21, 2024
@imnasnainaec imnasnainaec marked this pull request as ready for review October 21, 2024 14:05
@jasonleenaylor
Copy link
Contributor

.github/workflows/deploy_qa.yml line 95 at r2 (raw file):

              if [[ $VC > 0 ]]; then REM="v${VA}\.${VB}\.$((VC - 1))-.*"
              elif [[ $VB > 0 ]]; then REM="v${VA}\.$((VB - 1))\..*"
              else REM="v$((VA - 1))\..*"; fi

This is some fancy bash, I had to look it up. Very effective though.
I think a comment explaining what is being removed here would help future maintainers

Code quote:

          if [[ $TAG =~ ^v([0-9]+)\.([0-9]+)\.([0-9]+)-.* ]]; then
              VA=${BASH_REMATCH[1]}; VB=${BASH_REMATCH[2]}; VC=${BASH_REMATCH[3]}
              if [[ $VC > 0 ]]; then REM="v${VA}\.${VB}\.$((VC - 1))-.*"
              elif [[ $VB > 0 ]]; then REM="v${VA}\.$((VB - 1))\..*"
              else REM="v$((VA - 1))\..*"; fi

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 11 files at r1, 21 of 21 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 4078438 into master Oct 21, 2024
18 checks passed
@imnasnainaec imnasnainaec deleted the aws-ecr branch October 21, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment kubernetes maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants