Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize AutocompleteSetting as OffOnSetting #3488

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Generalize AutocompleteSetting as OffOnSetting #3488

merged 2 commits into from
Jan 8, 2025

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Dec 16, 2024

Prequel to #3445

This enum is already used for two settings: Vernacular Autocomplete and Gloss Spelling Suggestion. It would be nice to reuse it further, namely for Merge Protection Override.


This change is Reviewable

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base (cf6d1eb) to head (9a5d7e0).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/components/UserSettings/UserSettings.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3488      +/-   ##
==========================================
- Coverage   74.71%   74.63%   -0.09%     
==========================================
  Files         285      285              
  Lines       10996    10996              
  Branches     1337     1337              
==========================================
- Hits         8216     8207       -9     
- Misses       2398     2405       +7     
- Partials      382      384       +2     
Flag Coverage Δ
backend 83.54% <100.00%> (-0.18%) ⬇️
frontend 66.70% <66.66%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec marked this pull request as ready for review December 16, 2024 22:03
Copy link
Collaborator

@andracc andracc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 14 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec enabled auto-merge (squash) January 8, 2025 17:54
@imnasnainaec imnasnainaec merged commit 4d79491 into master Jan 8, 2025
18 checks passed
@imnasnainaec imnasnainaec deleted the off-on branch January 8, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants