Fix Linux (#251)

* README: recommend instaling python-is-python2
  * Required for Mercurial to run an Ubuntu 20.04
  * Related to https://jira.sil.org/browse/LT-20521
* Update TestBuild.sh to match the script in TeamCity
* LT-20610: Enable QA Server on Linux
  Fix case of LANGUAGEFORGESERVER environment variable
* LT-20323: Cosmetic Improvements
  * More space for labels (so Custom URL fits on Linux)
  * Fix the width of the Custom URL checkbox
  * Increase the default width
  * Make text boxes for username and password the same width
* Clean up: remove redundant IsUnix utility and unused delegates; clean up usings.

README.md

@@ -146,3 +146,7 @@ build using `UpdateDependencies.sh`:
 	cd chorus
 	./UpdateDependencies.sh
 
+##### Python
+
+Beginning with Ubuntu 20.04 (Focal), you will need to `sudo apt install python-is-python2` so that Mercurial can run.
+

build/TestBuild.sh

@@ -1,7 +1,9 @@
 #!/bin/bash
 cd "$(dirname "$0")/.."
 build/buildupdate.mono.sh
+export MONO_PREFIX=/usr
 . environ
-root=$PWD
-cd build
-xbuild "/target:${2:-Clean;Compile}" /property:Configuration="${1:-Debug}Mono" /property:RootDir=$root /property:BUILD_NUMBER="1.5.1.abcd" Chorus.proj
+# root=$PWD
+# cd build
+# xbuild "/target:${2:-Clean;Compile}" /property:Configuration="${1:-Debug}Mono" /property:RootDir=$root /property:BUILD_NUMBER="1.5.1.abcd" Chorus.proj
+xbuild /t:Compile /property:Configuration=DebugMono /property:BUILD_NUMBER="1.5.1.abcd" build/Chorus.proj

src/Chorus/UI/Clone/GetCloneFromInternetDialog.cs

@@ -61,7 +61,12 @@ public GetCloneFromInternetDialog(GetCloneFromInternetModel model)
 			_targetFolderControl.Anchor = (AnchorStyles.Bottom | AnchorStyles.Top | AnchorStyles.Left | AnchorStyles.Right);
 			_targetFolderControl._downloadButton.Click+=OnDownloadClick;
 			_targetFolderControl.Location = new Point(0, _serverSettingsControl.Height +10);
-			MinimumSize = new Size(_targetFolderControl.MinimumSize.Width+20, _targetFolderControl.Bottom +20);
+			var minimumWidth = Math.Max(_serverSettingsControl.MinimumSize.Width, _targetFolderControl.MinimumSize.Width) + 20;
+			MinimumSize = new Size(minimumWidth, _targetFolderControl.Bottom + 20);
+			// On Linux, we have to set the dialog width, then set the control width back to what it had been. TODO: different order
+			var sscWidth =  _serverSettingsControl.Width;
+			Width = sscWidth + 30;
+			_serverSettingsControl.Width = sscWidth;
 			if (_targetFolderControl.Bottom +30> Bottom)
 			{
 				this.Size = new Size(this.Width,_targetFolderControl.Bottom + 30);

src/Chorus/UI/Settings/SendReceiveSettings.cs

@@ -1,7 +1,6 @@
-using System;
+using System;
 using System.IO;
 using System.Windows.Forms;
-using Chorus.UI.Misc;
 using Chorus.Utilities.Help;
 using Chorus.VcsDrivers.Mercurial;
 using L10NSharp;

src/LibChorus/ChorusHub/ChorusHubOptions.cs

@@ -1,12 +1,12 @@
 using System;
 using System.IO;
-using Chorus.Utilities.code;
+using SIL.PlatformUtilities;
 
 namespace Chorus.ChorusHub
 {
 	public static class ChorusHubOptions
 	{
-		private static string _rootDirectory = LinuxUtils.IsUnix ? Path.Combine(Environment.GetEnvironmentVariable("HOME"), "ChorusHub") : @"C:\ChorusHub";
+		private static string _rootDirectory = Platform.IsUnix ? Path.Combine(Environment.GetEnvironmentVariable("HOME"), "ChorusHub") : @"C:\ChorusHub";
 
 		//these numbers were selected by looking at the IANA registry and intentionally *not* picking,
 		//"undefined" ones (which could become defined in the future), but rather ones already assigned to stuff

src/LibChorus/FileTypeHandlers/IChorusFileTypeHandler.cs

@@ -1,10 +1,4 @@
-using System;
 using System.Collections.Generic;
-using System.IO;
-using System.Linq;
-using System.Reflection;
-using Chorus.FileTypeHandlers.test;
-using Chorus.Utilities.code;
 using Chorus.merge;
 using Chorus.VcsDrivers.Mercurial;
 using SIL.IO;

src/LibChorus/FileTypeHandlers/xml/XmlTextChange.cs

@@ -1,7 +1,4 @@
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
 using System.Xml;
 using Chorus.Properties;
 using Chorus.VcsDrivers.Mercurial;

src/LibChorus/LibChorus.csproj

@@ -286,7 +286,6 @@
     <Compile Include="sync\DefaultSychronizerAdjunct.cs" />
     <Compile Include="sync\ISychronizerAdjunct.cs" />
     <Compile Include="sync\LargeFileFilter.cs" />
-    <Compile Include="Utilities\code\LinuxUtils.cs" />
     <Compile Include="Utilities\Help\HelpUtils.cs" />
     <Compile Include="Utilities\MakeRecordDictionary.cs" />
     <Compile Include="FileTypeHandlers\NotePresenter.cs" />
@@ -336,7 +335,6 @@
       <DependentUpon>AnnotationImages.resx</DependentUpon>
     </Compile>
     <Compile Include="notes\AnnotationClass.cs" />
-    <Compile Include="Utilities\code\DelegateDefinitions.cs" />
     <Compile Include="Utilities\MultiMap.cs" />
     <Compile Include="Utilities\UrlHelper.cs" />
     <Compile Include="Utilities\WebResponseHelper.cs" />

src/LibChorus/Model/ServerSettingsModel.cs

@@ -19,7 +19,7 @@ public class ServerSettingsModel
 	{
 		#region static and constant
 		private const string LanguageForge = "languageforge.org";
-		private const string ServerEnvVar = "LanguageForgeServer";
+		private const string ServerEnvVar = "LANGUAGEFORGESERVER";
 
 		public static string LanguageForgeServer
 		{

src/LibChorus/Utilities/FailureSimulator.cs

@@ -1,9 +1,5 @@
 using System;
-using System.Collections.Generic;
-using System.Diagnostics;
 using System.IO;
-using System.Text;
-using System.Threading;
 
 namespace Chorus.Utilities
 {

src/LibChorus/Utilities/ProcessStream.cs

@@ -1,7 +1,5 @@
 using System;
-using System.Collections.Generic;
 using System.Diagnostics;
-using System.Text;
 using System.Threading;
 
 namespace Chorus.Utilities

src/LibChorus/Utilities/UrlHelper.cs

@@ -1,8 +1,5 @@
 using System;
-using System.Collections.Generic;
-using System.Diagnostics;
 using System.Linq;
-using System.Text;
 using System.Text.RegularExpressions;
 using SIL.Reporting;
 

src/LibChorus/Utilities/ini/IniException.cs

@@ -9,11 +9,9 @@
 #endregion
 
 using System;
-using System.Security;
 using System.Globalization;
 using System.Security.Permissions;
 using System.Runtime.Serialization;
-using System.Runtime.Serialization.Formatters.Binary;
 
 
 namespace Nini.Ini

src/LibChorus/VcsDrivers/Mercurial/HgExceptions.cs

@@ -1,7 +1,4 @@
 using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
 
 namespace Chorus.VcsDrivers.Mercurial
 {

src/LibChorus/VcsDrivers/Mercurial/HgRunner.cs

@@ -4,8 +4,6 @@
 using System.ComponentModel;
 using System.Diagnostics;
 using System.IO;
-using System.Net.Mime;
-using System.Threading;
 using Chorus.Utilities;
 using SIL.Progress;
 using SIL.Reporting;

src/LibChorus/merge/text/PartialTextMerger.cs

@@ -1,8 +1,6 @@
 using System;
-using System.Collections.Generic;
 using System.Diagnostics;
 using System.IO;
-using System.Text;
 using Chorus.Utilities;
 
 namespace Chorus.merge.text

src/LibChorus/merge/xml/generic/DropTheirsMergeStrategy.cs

@@ -1,7 +1,5 @@
 using System.Collections.Generic;
-using System.Text;
 using System.Xml;
-using Chorus.merge.xml.generic;
 
 namespace Chorus.merge.xml.generic
 {

src/LibChorus/merge/xml/generic/FindNodeToMerge.cs

@@ -1,12 +1,10 @@
 #define USEOPTIMIZEDVERSION
 using System;
 using System.Collections.Generic;
-using SIL.Extensions;
 #if USEOPTIMIZEDVERSION
 using System.Linq;
 #endif
 using System.Text;
-using System.Web;
 using System.Xml;
 using Chorus.merge.xml.generic.xmldiff;
 using SIL.Code;

src/LibChorus/notes/AnnotationClass.cs

@@ -1,8 +1,5 @@
 using System;
-using System.Collections.Generic;
 using System.Drawing;
-using System.Linq;
-using System.Text;
 
 
 namespace Chorus.notes

src/LibChorus/notes/EmbeddedMessageContentHandlerRepository.cs

@@ -1,4 +1,4 @@
-// Copyright (c) 2015 SIL International
+// Copyright (c) 2015 SIL International
 // This software is licensed under the MIT License (http://opensource.org/licenses/MIT)
 using System;
 using System.Collections.Generic;
@@ -7,7 +7,7 @@
 using System.IO;
 using System.Linq;
 using System.Reflection;
-using Chorus.Utilities.code;
+using SIL.PlatformUtilities;
 
 namespace Chorus.notes
 {
@@ -38,7 +38,7 @@ public EmbeddedMessageContentHandlerRepository()
 			var libChorusAssembly = Assembly.GetExecutingAssembly();
 
 			//Set the codebase variable appropriately depending on the OS
-			var codeBase = libChorusAssembly.CodeBase.Substring(LinuxUtils.IsUnix ? 7 : 8);
+			var codeBase = libChorusAssembly.CodeBase.Substring(Platform.IsUnix ? 7 : 8);
 			var baseDir = Path.GetDirectoryName(codeBase);
 
 			// REVIEW: for some reason using *.* or *.dll didn't work - creating the catalogs in

src/LibChorus/notes/IAnnotationRepository.cs

@@ -1,7 +1,4 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
+using System.Collections.Generic;
 using SIL.Progress;
 
 namespace Chorus.notes

src/LibChorus/notes/IndexOfAllAnnotationsByKey.cs

@@ -1,5 +1,3 @@
-using System.Diagnostics;
-using System.Web;
 using Chorus.Utilities;
 
 namespace Chorus.notes