Remove unnecessary horizontal scroll in RTL UI #3263
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #3263 +/- ##
=========================================
Coverage ? 81.99%
=========================================
Files ? 605
Lines ? 35104
Branches ? 5713
=========================================
Hits ? 28783
Misses ? 5476
Partials ? 845 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Nateowami
reviewed
Jun 13, 2025
There was a problem hiding this comment.
This is kind of a blunt-force approach that doesn't get to the root of the problem, and could lead to different problems in the future. Based on my investigation, I believe the problem stems from .cdk-live-announcer-element using left: 0 instead of the logical inset-inline-start: 0
Reviewable status: 0 of 1 files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A horizontal scroll bar appears when the UI is changed to RTL. I think this occurred when we updated to implement material theme, but I did not go back to confirm. This change removes the unnecessary horizontal scroll bar.
This change is