Skip to content

SF-3419 Remove Lynx problems panel quotes and improve styling #3311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

siltomato
Copy link
Collaborator

@siltomato siltomato commented Jul 11, 2025

This PR removes the quotes from the sample text in the lynx problems panel. Also, the sample text is split into pre-insight/insight/post-insight parts so that they can be styled differently. Accordingly, the insight portion of the sample text is styled with background and text decoration like the editor insights.


This change is Reviewable

@siltomato siltomato added the will require testing PR should not be merged until testers confirm testing is complete label Jul 11, 2025
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 45.20548% with 40 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (4514be8) to head (4126fa5).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...nx-insights-panel/lynx-insights-panel.component.ts 41.17% 39 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3311      +/-   ##
==========================================
+ Coverage   82.55%   82.60%   +0.04%     
==========================================
  Files         605      605              
  Lines       35313    35316       +3     
  Branches     5745     5749       +4     
==========================================
+ Hits        29152    29172      +20     
+ Misses       5301     5285      -16     
+ Partials      860      859       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@siltomato siltomato marked this pull request as ready for review July 11, 2025 23:04
@Nateowami Nateowami changed the title SF-3419 Remove lynx problems panel quotes and improve styling SF-3419 Remove Lynx problems panel quotes and improve styling Jul 11, 2025
@pmachapman pmachapman self-assigned this Jul 13, 2025
@pmachapman pmachapman self-requested a review July 13, 2025 22:09
Copy link
Collaborator

@pmachapman pmachapman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@pmachapman pmachapman added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Jul 13, 2025
@siltomato siltomato force-pushed the fix/sf-3419-remove-quotes-from-lynx-text-snippets branch from 918f267 to 68a93e1 Compare July 18, 2025 19:18
@RaymondLuong3 RaymondLuong3 force-pushed the fix/sf-3419-remove-quotes-from-lynx-text-snippets branch from 68a93e1 to 4126fa5 Compare July 22, 2025 17:48
@pmachapman pmachapman added testing complete Testing of PR is complete and should no longer hold up merging of the PR and removed ready to test labels Jul 22, 2025
@pmachapman pmachapman merged commit e2cd8b2 into master Jul 22, 2025
18 checks passed
@pmachapman pmachapman deleted the fix/sf-3419-remove-quotes-from-lynx-text-snippets branch July 22, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing complete Testing of PR is complete and should no longer hold up merging of the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants