Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fuc_Arab] Add new file #34

Merged
merged 2 commits into from
Oct 10, 2024
Merged

[fuc_Arab] Add new file #34

merged 2 commits into from
Oct 10, 2024

Conversation

LornaSIL
Copy link
Contributor

@emily-roth could you review this first?

@emily-roth
Copy link
Contributor

emily-roth commented Oct 9, 2024 •
edited
Loading

Looks good based on the file, have you run any sldr tests on it yet or would you like me to?
Edit: @LornaSIL I ran tests myself, it looks like there's an autonym error where the autonym listed contains ُ (U+064F) but the exemplars do not. Is that a missing character in the exemplar, or an error with the autonym? Everything else passes.

@LornaSIL
Copy link
Contributor Author

LornaSIL commented Oct 9, 2024

Thanks. Definitely an error on my part. The autonym is correct.

@emily-roth emily-roth merged commit ebabac3 into master Oct 10, 2024
@LornaSIL LornaSIL deleted the fuc_Arab branch October 10, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@emily-roth emily-roth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LornaSIL @emily-roth