Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plrd] Update/Add Miao language use #35

Merged
merged 5 commits into from
Oct 10, 2024
Merged

[Plrd] Update/Add Miao language use #35

merged 5 commits into from
Oct 10, 2024

Conversation

LornaSIL
Copy link
Contributor

@LornaSIL LornaSIL commented Oct 8, 2024

These changes and additions are based on the information learned from creating the UTN.

@LornaSIL LornaSIL requested a review from emily-roth October 8, 2024 21:46
@emily-roth
Copy link
Contributor

I need to fix the indentations and then I'll look them over and run tests

@emily-roth
Copy link
Contributor

@LornaSIL do you have the sources from which you built the collations? AKA did they hand you fully written collations or did they give you a description of the sort order and you wrote the collation? I'm trying to figure out why our collation tests are saying that they all have invalid ICU collation

@emily-roth
Copy link
Contributor

Update: I'm 90% sure they are failing because they each have at least one instance of a reset (the ampersand) without any relationships following them (the arrows). For example in ywq, line 41 just has &𖼹 instead of &𖼹 < something. If you mean for 𖼹 to follow 𖼎 in primary sort order and follow 𖼎𖽑 if secondary sort is being taken into account, you would want it to combine lines 40 and 41 so that it says &𖼎 << 𖽐𖼎 << 𖼎𖽑 < 𖼹. If that's not the reason why the lonely resets are there, though, let me know

@emily-roth emily-roth merged commit 2cf7a75 into master Oct 10, 2024
@LornaSIL LornaSIL deleted the plrd branch October 10, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants