Skip to content

Commit

Permalink
[issue982] code review
Browse files Browse the repository at this point in the history
  • Loading branch information
FlorianPommerening committed Feb 9, 2021
1 parent 164a57a commit 75f18d1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
9 changes: 6 additions & 3 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,15 @@ after the corresponding tracker issues.
methods were renamed. This class will undergo further changes in the future.
<http://issues.fast-downward.org/issue989>

- Debug builds with LP solvers
- Debug builds with LP solvers vs. the _GLIBCXX_DEBUG flag
<http://issues.fast-downward.org/issue982>
Previously, we used the flag _GLIBCXX_DEBUG in debug builds for additional
checks. This makes the binary incompatible with external libraries such as
LP solvers. The flag is now disabled by default and can be enabled with the
CMake option USE_GLIBCXX_DEBUG.
LP solvers. The flag is now disabled by default. If no LP solvers are present
or LP solvers are disabled, it can be enabled by setting the CMake option
USE_GLIBCXX_DEBUG. The build configurations debugnolp and releasenolp have
been removed, and the build configuration glibcxx_debug has been added.



## Fast Downward 20.06
Expand Down
2 changes: 1 addition & 1 deletion src/search/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ project(downward)
# https://stackoverflow.com/questions/7637539/how-to-split-strings-across-multiple-lines-in-cmake
option(
USE_GLIBCXX_DEBUG
"When compiling with g++ enable the libstdc++ debug mode that does additional safety checks. The checks come at a performance cost and should only be enabled in debug mode. Additionally, enabling them will make the binary incompatible with libraries that are not compiled with this flag which can lead to hard-to-debug errors."
"Enable the libstdc++ debug mode that does additional safety checks. (On Linux systems, g++ and clang++ usually use libstdc++ for the C++ library.) The checks come at a significant performance cost and should only be enabled in debug mode. Enabling them makes the binary incompatible with libraries that are not compiled with this flag, which can lead to hard-to-debug errors."
FALSE)

fast_downward_set_compiler_flags()
Expand Down

0 comments on commit 75f18d1

Please sign in to comment.