Fix when the namespace contains 'Controller'

Check the reflection instance type instead of instantiating the class. Instantiating throws errors for __construct with arguments
silverleague · Nov 28, 2022 · 134580b · 134580b
1 parent 0589668
commit 134580b
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/Generators/AbstractTagGenerator.php b/src/Generators/AbstractTagGenerator.php
@@ -214,7 +214,7 @@ protected function generateOwnerTags()
         if ($reflection->isAbstract()) {
             return;
         }
-        if (Injector::inst()->get($this->className) instanceof Extension) {
+        if ($reflection instanceof Extension) {
             $owners = iterator_to_array($this->getOwnerClasses($className));
             $owners[] = $this->className;
             $tagString = sprintf('\\%s $owner', implode("|\\", array_values($owners)));

diff --git a/src/Generators/ControllerTagGenerator.php b/src/Generators/ControllerTagGenerator.php
@@ -42,7 +42,12 @@ protected function generateTags()
      */
     protected function generateControllerObjectTags()
     {
-        $pageClassname = str_replace(['_Controller', 'Controller'], '', $this->className);
+        $shortName = ClassInfo::shortName($this->className);
+        // Strip "Controller" or "_Controller" from the class short name
+        $shortSansController = str_replace(['_Controller', 'Controller'], '', $shortName);
+        // And push it back in :)
+        $pageClassname = str_replace($shortName, $shortSansController, $this->className);
+
         if (class_exists($pageClassname) && $this->isContentController($this->className)) {
             $pageClassname = $this->getAnnotationClassName($pageClassname);