Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mobile Detect library http://mobiledetect.net/ #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mlewis-everley
Copy link

Mobile Detect is an actively developed PHP class that provides a large quantity of mobile and tablet detection tools.

My thinking was to remove the current "MobileBrowserDetector" class and instead connect the mobile module to the Mobile Detect class (allowing the core dev's to focus on integrating this class with Silverstripe, rather than writing mobile detection rules).

All thoughts, comments, critiques welcome :-)

Mo

@wilr
Copy link
Member

wilr commented Oct 11, 2013

Since MobileBrowserDetector is public might have to keep it round, perhaps through a deprecated warning for a release or 2. Like the idea of using more robust tools.

@dhensby
Copy link
Contributor

dhensby commented Nov 21, 2015

This isn't the best implementation. If we want to allow pluggable mobile detection backends then we should be using injector and defining an interface.

I think that's probably overkill, though.

We should pull this in with composer and either release a new major version scrapping the old class or we just modify the existing class to use mobile detect.

Fyi: https://github.com/serbanghita/Mobile-Detect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants