Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken builds, merge-ups, and licenses #357

Open
github-actions bot opened this issue Dec 31, 2024 · 6 comments
Open

Broken builds, merge-ups, and licenses #357

github-actions bot opened this issue Dec 31, 2024 · 6 comments
Assignees

Comments

@github-actions
Copy link

github-actions bot commented Dec 31, 2024

This is an automatically created issue used to remind the Silverstripe CMS Squad to look at broken builds and merge-ups every Tuesday.

It was created by the .github/workflows/rhino-issue.yml workflow in the silverstripe/.github repository.

Triage instructions

  1. Put on the following label:
  • type/other
  1. Move this issue to the "Ready" column on our internal zenhub board

Broken builds:

Merge-ups:

Licenses:

PRs

@emteknetnz
Copy link
Member

emteknetnz commented Jan 8, 2025

Have checked licenses on 5 and 6.0 branches, and performed merge-ups on supported modules

@GuySartorelli GuySartorelli self-assigned this Jan 8, 2025
@GuySartorelli
Copy link
Member

GuySartorelli commented Jan 8, 2025

Have checked licenses on 5 and 6.0 branches

The message in the issue implies 5.3 should be checked as well since it's a patch branch: "Manually run the workflow on other supported branches, including minor and patch"

We probably shouldn't be mucking around with dependencies in patch releases though, so I'd be okay with removing that requirement from this and future issues.

@GuySartorelli
Copy link
Member

PRs merged. Reassigning to Steve to look at my comment about about licenses and to double check everything is now green.

@GuySartorelli
Copy link
Member

@emteknetnz Still need to address #357 (comment)

@emteknetnz
Copy link
Member

I think we should check 5.3 and potentially update deps in a patch, there is a small chance that a dependency-of-a-dependency ends up with a GPLv2 license, and we need to catch that early.

The licenses.yml workflow isn't available on 5.3 of kitchen-sink, so I've created a backport PR

@GuySartorelli
Copy link
Member

PR merged, reassigning to Steve in case there's anything left to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants