-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken builds, merge-ups, and licenses #357
Comments
Have checked licenses on 5 and 6.0 branches, and performed merge-ups on supported modules |
The message in the issue implies We probably shouldn't be mucking around with dependencies in patch releases though, so I'd be okay with removing that requirement from this and future issues. |
PRs merged. Reassigning to Steve to look at my comment about about licenses and to double check everything is now green. |
@emteknetnz Still need to address #357 (comment) |
I think we should check 5.3 and potentially update deps in a patch, there is a small chance that a dependency-of-a-dependency ends up with a GPLv2 license, and we need to catch that early. The licenses.yml workflow isn't available on 5.3 of kitchen-sink, so I've created a backport PR |
PR merged, reassigning to Steve in case there's anything left to do |
This is an automatically created issue used to remind the Silverstripe CMS Squad to look at broken builds and merge-ups every Tuesday.
It was created by the
.github/workflows/rhino-issue.yml
workflow in the silverstripe/.github repository.Triage instructions
type/other
Broken builds:
Merge-ups:
Licenses:
PRs
The text was updated successfully, but these errors were encountered: