FIX Use latest compatible version of installer #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
commented
Jan 8, 2025
| @@ -375,7 +377,7 @@ private function getListOfPhpVersionsByBranchName(): array | |||
| $json = $this->getComposerJsonContent(); | |||
| if ($json) { | |||
| $php = $json->require->php ?? null; | |||
| $php = str_replace('^', '', $php); | |||
| $php = str_replace('^', '', $php ?? ''); | |||
There was a problem hiding this comment.
Fixes deprecation notice in php 8.3 - Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in path/to/gha-generate-matrix/job_creator.php on line 378
|
I was worried this might cause a regression of #93 but your implementation for that was to start by completely removing the version of installer which the matrix includes, so this change will be fine in that regard - though we don't have a "prefer-lowest" for behat. |
|
Yeah that's probably correct actually, we should use the lowest version of installer to catch regressions caused by the wrong constraints |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#357
Indirectly fixes a behat test which broke because CI was using framwork 5.2 instead of 5.3 due to the corresponding version of installer being used, where there this line was different - 5.2 - 5.3
gha-generate-matrix INSTALLER_TO_REPO_MINOR_VERSIONS has graphql 5.2 for both installer 5.2 and installer 5.3. We should use the latest version of installer that matches in this scenario, rather than the first one