Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC Deprecate passing null paramters for Form and ValidationResult methods #678

Merged
merged 1 commit into from
Jan 30, 2025
Merged

DOC Deprecate passing null paramters for Form and ValidationResult methods #678

merged 1 commit into from
Jan 30, 2025

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Jan 17, 2025
Open
3 tasks
@emteknetnz emteknetnz force-pushed the pulls/5/depr-form-valid branch from 64eca78 to a614a6f Compare January 17, 2025 04:34
@emteknetnz emteknetnz changed the title API Deprecate passing null paramters for Form and ValidationResult methods DOC Deprecate passing null paramters for Form and ValidationResult methods Jan 17, 2025
@emteknetnz emteknetnz marked this pull request as ready for review January 17, 2025 04:43
GuySartorelli
GuySartorelli requested changes Jan 29, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add notes for the methods on Form as well.

@emteknetnz emteknetnz force-pushed the pulls/5/depr-form-valid branch from a614a6f to ed642f2 Compare January 29, 2025 21:14
@emteknetnz
Copy link
Member Author

Updated

GuySartorelli
GuySartorelli approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli
Copy link
Member

Conflict

@emteknetnz emteknetnz force-pushed the pulls/5/depr-form-valid branch from ed642f2 to 4a4fb2f Compare January 29, 2025 23:43
@emteknetnz
Copy link
Member Author

Updated

@GuySartorelli GuySartorelli merged commit 4728462 into silverstripe:5 Jan 30, 2025
3 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/depr-form-valid branch January 30, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli