Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Add MFA docs #292

Merged
merged 1 commit into from
Apr 9, 2024
Merged

ENH Add MFA docs #292

merged 1 commit into from
Apr 9, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Apr 8, 2024
Closed
5 tasks
GuySartorelli
GuySartorelli requested changes Apr 8, 2024
View reviewed changes
sources-user.js Outdated
Comment on lines 21 to 29
{
resolve: `gatsby-source-git`,
options: {
name: `user--5--optional_features/mfa`,
remote: `https://github.com/silverstripe/silverstripe-mfa`,
branch: `5.2`,
patterns: `docs/en/userguide/**`,
}
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
resolve: `gatsby-source-git`,
options: {
name: `user--5--optional_features/mfa`,
remote: `https://github.com/silverstripe/silverstripe-mfa`,
branch: `5.2`,
patterns: `docs/en/userguide/**`,
}
},

MFA is already in this file, so this is a duplicate entry.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

GuySartorelli
GuySartorelli approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this, #294, and #295 will conflict with each other - you might want to combine them into a single PR since I won't merge any of them until all the docs PRs are merged anyway.

But looks good to me.

@GuySartorelli
Copy link
Member

Conflict to resolve. I strongly recommend combining these three PRs into one.

@emteknetnz
Copy link
Member Author

Combined

@GuySartorelli
Copy link
Member

Netlify is complaining:

Error processing Markdown file /opt/build/repo/.cache/gatsby-source-git/docs--5--optional_features/mfa/docs/en/02_creating-new-mfa-methods/01_creating-mfa-method-frontend.md:
5:02:27 PM: incomplete explicit mapping pair; a key node is missed; or followed by a non-tabulated empty line at line 2, column 33:
5:02:27 PM: title: Creating a new MFA method: front-end
5:02:27 PM: ^

I think it doesn't like having a colon in a metadata title.

@emteknetnz
Copy link
Member Author

Have created PR to change colon to dash silverstripe/silverstripe-mfa#534

@GuySartorelli
Copy link
Member

Netlify is appeased.
deploy summary
new preview

@GuySartorelli GuySartorelli merged commit d0bc35b into silverstripe:master Apr 9, 2024
4 of 8 checks passed
@GuySartorelli GuySartorelli deleted the pulls/master/mfa branch April 9, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli