MNT Replace sass-lint with stylelint #22
Merged
+99
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/1.1/stylelint
branch
from
813f039 to
78206cc
Compare
sabina-talipova
force-pushed
the
pulls/1.1/stylelint
branch
from
78206cc to
60341f2
Compare
| @@ -0,0 +1,99 @@ | |||
| module.exports = { | |||
| 'defaultSeverity': 'warning', | |||
There was a problem hiding this comment.
I'm okay with this line being here for now, but I've added an AC for it to be removed as part of silverstripe/.github#228
GuySartorelli
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stylelint has about 100 rules, which are turned on by default (See).
This PR removed support of old
sass-lintand implemented newstylelint. New file.stylelintrc.ymladd some configuration for default rules and also turn off some rules that we doesn't support. Probably they required additional review.Issues