Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Allow patch tag workflow to be dispatched correctly. #146

Merged

Conversation

GuySartorelli
Copy link
Member

Two changes were made here:

  1. Don't check for the presence of the file up front. Turns out the actions/checkout action is per-job. So we'd have to run that again in this job for it to work. Instead, we can just check the response code of the request, and if it's a 404 we know the file wasn't there.
  2. Add the actions:write permission. This is required, or else we get a 403 response code.

I have tested this in a repo I control, and found both of these changes are necessary for it to work as expected.

I have also pulled this fork in a repo I control to check and the new permission does need to be added in ci.yml for community members: https://github.com/GuySartorelli/silverstripe-composable-validators/actions/runs/10275469540
I've added back the warning from #139 (comment) as a result.

Issue

@emteknetnz emteknetnz merged commit b0930f7 into silverstripe:1.14 Aug 7, 2024
2 checks passed
@emteknetnz emteknetnz deleted the pulls/1.14/dispatch-patches branch August 7, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants