Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Don't include installer if it's not needed #76

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented Jan 26, 2024

Description

Whenever we add a new repository that isn't a module/recipe/theme, we have to update a constant in order to tell the matrix generator not to add installer for it.

Instead of doing that, the generator just shouldn't try to add installer for those. Anything that isn't a recipe, a module, or a theme but which needs installer for its tests to run should explicitly add installer as a dev dependency.

I'm making this change instead of adding the new standards repo to the const.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • CI is green

@GuySartorelli GuySartorelli force-pushed the pulls/1/no-installer-unless-stated branch from e801c61 to e304cd2 Compare January 26, 2024 03:01
@emteknetnz emteknetnz merged commit b6cb670 into silverstripe:1 Jan 28, 2024
4 checks passed
@emteknetnz emteknetnz deleted the pulls/1/no-installer-unless-stated branch January 28, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants