Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing on dnadesign/silverstripe-elemental but passes locally #23

Closed
GuySartorelli opened this issue Aug 28, 2023 · 2 comments
Closed
Assignees
Labels

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Aug 28, 2023

16 tests fail when gha-update-js is run against the dnadesign/silverstripe-elemental repository.
Failures look like this:

FAIL client/src/components/ElementEditor/tests/Header-test.js
● Test suite failed to run

TypeError: (0 , _jestUtil.invariant) is not a function
at eventHandler (node_modules/jest-circus/build/eventHandler.js:248:31)

These tests pass fine locally.

Possible causes:

  • different npm version
  • different yarn version
  • ???

Additional output that gha-update-js should give us that might help debugging this sort of thing:

  • yarn version and npm version clearly near the top or bottom of the full run
  • include package.json and package.lock in artifacts

Failed PRs

@emteknetnz
Copy link
Member

update-js workflow magincally started working again on elemental, have linked PR

Have created another PR on gha-update-js to output version numbers of node, npm and yarn and also adding package.json and yarn.lock to artifacts

@emteknetnz emteknetnz removed their assignment Sep 4, 2023
@GuySartorelli GuySartorelli self-assigned this Sep 4, 2023
@GuySartorelli
Copy link
Member Author

Weird that it's working now but hey at least that's less time spent debugging. Good to have those extra datapoints for next time too.
PRs merged. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants