DEP Update JS dependencies #1088
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 24, 2023
emteknetnz
force-pushed
the
pulls/5/update-js
branch
2 times, most recently
from
a9a0e41
to
8682ad5
Compare
emteknetnz
force-pushed
the
pulls/5/update-js
branch
from
8682ad5
to
e88d31e
Compare
emteknetnz
force-pushed
the
pulls/5/update-js
branch
from
e88d31e
to
fe5706d
Compare
|
I created silverstripe/gha-update-js#23 to look into this failure - gonna close the PR as it's easy enough to reopen if we want it but it's providing no additional value by being left open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#90
Replacement for #1087, which I'm honestly not sure why is failing in CI
yarn testpasses on my localI think it's failing for some sort of js export/import reason
I copied the new babel bits in package.json from silverstripe/admin
Update: still failing - I really have no idea why this is failing in CI