Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Dependencies for CMS 6 #50

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Feb 19, 2024

Issue silverstripe/.github#191

Requires silverstripe/silverstripe-graphql-devtools#52 to be merged first

silverstripe/recipe-plugin and silverstripe/graphql-devtools are intentionally not being incremented

This PR shouldn't be merged until fluent has an 8 branch created and this PR is updated to use it

We've agreed on slack to temporarily remove fluent from the sink

Have created follow up card to add it back in - #52

@emteknetnz emteknetnz force-pushed the pulls/6/module-standardiser-1708317250 branch 2 times, most recently from 8ae3cf8 to 9f0aede Compare February 19, 2024 05:18
@emteknetnz emteknetnz marked this pull request as draft February 19, 2024 05:19
@emteknetnz emteknetnz marked this pull request as ready for review February 20, 2024 22:45
@emteknetnz emteknetnz force-pushed the pulls/6/module-standardiser-1708317250 branch from 9f0aede to 15b597e Compare February 20, 2024 22:46
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build failures are expected for now.

@maxime-rainville maxime-rainville merged commit c377eb5 into silverstripe:6 Feb 21, 2024
5 of 22 checks passed
@maxime-rainville maxime-rainville deleted the pulls/6/module-standardiser-1708317250 branch February 21, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants