DEP Conflict with incompatible version of elemental #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
approved these changes
Jul 29, 2024
emteknetnz
requested changes
Jul 29, 2024
GuySartorelli
force-pushed
the
pulls/2/conflict-lower-elemental
branch
from
82ba355 to
1a787f9
Compare
GuySartorelli
changed the title
GuySartorelli
force-pushed
the
pulls/2/conflict-lower-elemental
branch
from
1a787f9 to
f8883e2
Compare
GuySartorelli
changed the title
|
Done |
|
Note job 3 CI failure is pre-existing. See https://github.com/silverstripe/silverstripe-admin/actions/runs/10123308730 |
emteknetnz
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/silverstripe/silverstripe-graphql/actions/runs/10086656540/job/28024281063
Graphql branch
5uses the^5constraint to pull in elemental, which gets5.2.*right now because those are the stable tags.It turns out elemental
5.2and admin2.3are incompatible with one another. Adding thisconflictto admin results in getting the5.x-devconstraint for elemental instead, which will pass happily.An alternative would be to change the constraint in graphql from
^5to5.x-devbut then when we release 5.3 we'll still have the5.x-devconstraint so we'd have the opposite problem, where the next minor is being pulled in when testing against graphql 5.3.issue