DEP Upgrade build stack #1303
Merged
DEP Upgrade build stack #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
GuySartorelli
force-pushed
the
pulls/2/build-stack
branch
2 times, most recently
from
ac257af to
6fbe254
Compare
GuySartorelli
force-pushed
the
pulls/2/build-stack
branch
2 times, most recently
from
021752b to
249c137
Compare
GuySartorelli
force-pushed
the
pulls/2/build-stack
branch
6 times, most recently
from
7ccc362 to
71fca2d
Compare
GuySartorelli
force-pushed
the
pulls/2/build-stack
branch
from
71fca2d to
e584597
Compare
GuySartorelli
commented
Dec 13, 2022
Comment on lines
-57
to
+61
| componentWillReceiveProps(props) { | ||
| static getDerivedStateFromProps(props) { |
There was a problem hiding this comment.
componentWillReceiveProps is deprecated and has been removed in React 18 - see this blog post.
The idea to use the static getDerivedStateFromProps method came from this blog post
|
Check the comments in silverstripe/silverstripe-admin#1389 before reviewing this PR, as it will explain some of the changes made here. |
|
behat tests are allowed to fail at Max's request - we'll fix those up after all of the related PRs are merged. |
GuySartorelli
force-pushed
the
pulls/2/build-stack
branch
from
e584597 to
8606f34
Compare
emteknetnz
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue