Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Fix scss linting warnings #309

Merged
merged 1 commit into from
Jun 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .stylelintignore

This file was deleted.

2 changes: 1 addition & 1 deletion client/dist/styles/bundle.css

Large diffs are not rendered by default.

8 changes: 1 addition & 7 deletions client/src/containers/CampaignAdmin/CampaignAdmin.scss
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
}

.campaign-admin__empty-info {
padding: calc(270px + 0.5em) $panel-padding-x 0 $panel-padding-x;
padding: calc(270px + 0.5em) $panel-padding-x 0;
background-image: url("images/empty-campaign-preview.png");
background-repeat: no-repeat;
background-position: 50% 0;
Expand Down Expand Up @@ -122,12 +122,6 @@
}
}

.list-group-item:hover {
.campaign-admin__item-links--is-linked {
opacity: 1;
}
}
Comment on lines -125 to -129
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a duplicate of the same thing earlier in this file.


.campaign-admin__unremoveable-item {
margin-bottom: 0;
padding-left: 35px;
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"css": "yarn && WEBPACK_CHILD=css webpack -p --bail --progress",
"test": "jest",
"coverage": "jest --coverage",
"lint": "eslint client/src && stylelint **/client/src/**/*.scss"
"lint": "eslint client/src && stylelint client/src"
},
"repository": {
"type": "git",
Expand Down Expand Up @@ -49,7 +49,7 @@
"redux-thunk": "^2.4.2"
},
"devDependencies": {
"@silverstripe/eslint-config": "^1.2.1",
"@silverstripe/eslint-config": "^1.3.0",
"@silverstripe/webpack-config": "^2.1.0",
"@testing-library/react": "^14.0.0",
"babel-core": "^6.26.3",
Expand Down
Loading
Loading