Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More padding for column checkboxes (in gridfieldextensions) #101

Open
brynwhyman opened this issue Jan 9, 2019 · 4 comments
Open

More padding for column checkboxes (in gridfieldextensions) #101

brynwhyman opened this issue Jan 9, 2019 · 4 comments

Comments

@brynwhyman
Copy link

brynwhyman commented Jan 9, 2019

Update styling so the whole cell/padding for column's 'in results'/'in detail' checkbox is selectable.

Action this in: symbiote/silverstripe-gridfieldextensions#281

@robbieaverill
Copy link
Contributor

I think this needs to be raised on symbiote/silverstripe-gridfieldextensions, since that's the component that renders the inline editable checkboxes and the same request here would be valid for all implementations of it.

Things to consider when doing this:

  • We may need to add a label for the checkbox in order to make it clickable
  • The label needs to be accessible and not confuse screenreaders
  • The checkbox identifies the column header as its label at the moment, we'd need to change that to the label

@robbieaverill
Copy link
Contributor

Thoughts @brynwhyman?

@ScopeyNZ
Copy link
Contributor

I agree it belongs on GridFieldExtensions. I think there should be a variant (probably through configuration) that allows label-less checkboxes in columns. It can still be screen reader friendly with appropriate html attributes. I personally would prefer that it also involve making the whole table cell the label for the checkbox - ie. making a click anywhere on the cell toggle the checkbox.

@brynwhyman
Copy link
Author

Moved to: symbiote/silverstripe-gridfieldextensions#281

I'll keep this ticket in CKAN to track whether we action this as part of the CKAN initiative currently underway.

@brynwhyman brynwhyman changed the title More padding for column checkboxes More padding for column checkboxes (in gridfieldextensions) Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants