-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase clickable area for inline checkboxes #281
Comments
Originally raised in: silverstripe/silverstripe-ckan-registry#101 From @ScopeyNZ:
|
@robbieaverill this change sounds good to me. I've used checkboxes in cells previously, and they've always been much nicer to use when the entire cell was clickable. It's also possible to capture this click event in the cell and toggle the checkbox based on that using JS (assuming we can target it reliably); I can't foresee any accessibility issues with that approach since it should remain how it is now for the most part (e.g. keyboard accessible and no label changes). Thoughts? |
Yeah sounds good. So it's probably worth checking whether we need to add a label to go with the checkbox for screenreaders - if so, update the styles etc so the label takes up the whole column. If not, we could do as @nglasl suggested and use a JS click handler on the table cell to trigger a change on the checkbox. |
I think it makes sense to update the styling so the whole cell/padding for column's inline editable checkbox is selectable.
Things to consider when doing this:
The text was updated successfully, but these errors were encountered: