MNT Run module-standardiser (#222)

silverstripe · Feb 2, 2024 · cfc2294 · cfc2294
1 parent f04e9fa
commit cfc2294
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 8 deletions.
diff --git a/composer.json b/composer.json
@@ -33,7 +33,9 @@
     "require-dev": {
         "silverstripe/recipe-testing": "^3",
         "squizlabs/php_codesniffer": "^3",
-        "symbiote/silverstripe-queuedjobs": "^5"
+        "symbiote/silverstripe-queuedjobs": "^5",
+        "silverstripe/standards": "^1",
+        "phpstan/extension-installer": "^1.3"
     },
     "suggest": {
         "symbiote/silverstripe-queuedjobs": "Automatically schedules content review emails to be sent, only requiring one crontask to be created"
@@ -52,4 +54,4 @@
     },
     "minimum-stability": "dev",
     "prefer-stable": true
-}
+}
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
@@ -0,0 +1,3 @@
+parameters:
+  paths:
+    - src
diff --git a/src/Extensions/ContentReviewDefaultSettings.php b/src/Extensions/ContentReviewDefaultSettings.php
@@ -11,6 +11,7 @@
 use SilverStripe\Forms\TextareaField;
 use SilverStripe\Forms\TextField;
 use SilverStripe\ORM\DataExtension;
+use SilverStripe\ORM\ManyManyList;
 use SilverStripe\Security\Group;
 use SilverStripe\Security\Member;
 use SilverStripe\Security\Permission;
@@ -21,8 +22,8 @@
  * review setting.
  *
  * @property int $ReviewPeriodDays
- * @method SilverStripe\ORM\ManyManyList<Group> ContentReviewGroups()
- * @method SilverStripe\ORM\ManyManyList<Member> ContentReviewUsers()
+ * @method ManyManyList<Group> ContentReviewGroups()
+ * @method ManyManyList<Member> ContentReviewUsers()
  *
  * @extends DataExtension<SiteConfig>
  */

diff --git a/src/Extensions/ContentReviewOwner.php b/src/Extensions/ContentReviewOwner.php
@@ -5,11 +5,12 @@
 use SilverStripe\CMS\Model\SiteTree;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\ORM\DataExtension;
+use SilverStripe\ORM\ManyManyList;
 use SilverStripe\Security\Group;
 use SilverStripe\Security\Member;
 
 /**
- * @method SilverStripe\ORM\ManyManyList<SiteTree> SiteTreeContentReview()
+ * @method ManyManyList<SiteTree> SiteTreeContentReview()
  *
  * @extends DataExtension<Group|Member>
  */

diff --git a/src/Extensions/SiteTreeContentReview.php b/src/Extensions/SiteTreeContentReview.php
@@ -27,6 +27,8 @@
 use SilverStripe\ORM\DataExtension;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\DB;
+use SilverStripe\ORM\HasManyList;
+use SilverStripe\ORM\ManyManyList;
 use SilverStripe\ORM\FieldType\DBDate;
 use SilverStripe\ORM\FieldType\DBDatetime;
 use SilverStripe\ORM\SS_List;
@@ -50,9 +52,9 @@
  * @property string $LastEditedByName
  * @property string $OwnerNames
  *
- * @method SilverStripe\ORM\ManyManyList<Group> ContentReviewGroups()
- * @method SilverStripe\ORM\ManyManyList<Member> ContentReviewUsers()
- * @method SilverStripe\ORM\HasManyList<ContentReviewLog> ReviewLogs()
+ * @method ManyManyList<Group> ContentReviewGroups()
+ * @method ManyManyList<Member> ContentReviewUsers()
+ * @method HasManyList<ContentReviewLog> ReviewLogs()
  *
  * @extends DataExtension<SiteTree>
  */