fix: getPage returning the wrong page

If you programaticaly update the ParentID of an element, getPage() still returns the outdated page.
silverstripe · Aug 17, 2023 · 65f4c70 · 65f4c70
1 parent 8bc68fe
commit 65f4c70
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -4,3 +4,6 @@
 /vendor/
 /resources/
 /assets/
+/public
+.phpunit.result.cache
+composer.lock
diff --git a/src/Models/BaseElement.php b/src/Models/BaseElement.php
@@ -698,8 +698,7 @@ public function getSimpleClassName()
      */
     public function getPage()
     {
-        // Allow for repeated calls to be cached
-        if (isset($this->cacheData['page'])) {
+        if (isset($this->cacheData['page']) && !$this->isChanged('ParentID')) {
             return $this->cacheData['page'];
         }
 

diff --git a/tests/BaseElementTest.php b/tests/BaseElementTest.php
@@ -511,4 +511,18 @@ public function testGetContentForCmsSearch()
         $element = $this->objFromFixture(TestElement::class, 'elementDataObject3');
         $this->assertSame('Hello Test|#|Element 3', $element->getContentForCmsSearch());
     }
+
+
+    public function testGetPage()
+    {
+        $element = $this->objFromFixture(ElementContent::class, 'content1');
+
+        $this->assertStringContainsString($element->getPage()->Title(), 'Test Elemental');
+
+        $updatePage = $this->objFromFixture(TestPage::class, 'page_with_elements');
+
+        $element->ParentID = $updatePage->ID;
+
+        $this->assertStringContainsString($element->getPage()->Title(), 'Page with elements');
+    }
 }