Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added $startIndex param to Pos method #1225

Open
wants to merge 1 commit into
base: 6
Choose a base branch
from
Open

Added $startIndex param to Pos method #1225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Models/BaseElement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1261,11 +1261,12 @@ public function TotalItems()
/**
* Returns the position of the current element.
*
* @param int $startIndex Number to start count from.
* @return int
*/
public function Pos()
public function Pos($startIndex = 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public function Pos($startIndex = 1)
public function Pos(int $startIndex = 1)

{
return ($this->Parent()->Elements()->filter('Sort:LessThan', $this->Sort)->count() + 1);
return ($this->Parent()->Elements()->filter('Sort:LessThan', $this->Sort)->count() + $startIndex);
}

/**
Expand Down