NEW Show CMS field (top-level) tabs in more actions dropdown #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
robbieaverill
suggested changes
Sep 4, 2018
ScopeyNZ
force-pushed
the
pulls/4/edit-tab-le
branch
from
f116276 to
c0fd57b
Compare
|
Updated from feedback 🙂 |
robbieaverill
suggested changes
Sep 5, 2018
ScopeyNZ
force-pushed
the
pulls/4/edit-tab-le
branch
2 times, most recently
from
df37c9c to
55411b2
Compare
|
Updated again and rebased. |
ScopeyNZ
force-pushed
the
pulls/4/edit-tab-le
branch
from
55411b2 to
ba53b3a
Compare
robbieaverill
suggested changes
Sep 6, 2018
_config/config.yml
Outdated
| namespace: "ElementTabCache" | ||
| DNADesign\Elemental\Services\ElementTabProvider: | ||
| properties: | ||
| cache: %$Psr\SimpleCache\CacheInterface.ElementTabCache |
There was a problem hiding this comment.
I think it's always safest to quote injector definitions like this, I've had problems without quoting them before. Also we could put these config definitions into a new cache.yml file
robbieaverill
force-pushed
the
pulls/4/edit-tab-le
branch
from
d215222 to
d54b32d
Compare
robbieaverill
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces tab names to the "more actions" dropdown on individual elements in the elemental editor. This includes:
Resolves #323