Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Dependencies for CMS 6 #24

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Feb 22, 2024

Issue silverstripe/.github#191

CI won't work until this PR and silverstripe/silverstripe-graphql#575 are merged. Since this PR is required for CI to work please just merge as is

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove dependency on this eventually but agree that for now merging makes sense to get everything else working.
LGTM. Failures are expected at this stage so ignoring CI.

@GuySartorelli GuySartorelli merged commit 2e8198d into silverstripe:2 Feb 23, 2024
5 of 9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/2/cms6 branch February 23, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants