FIX Respect explicit casting before casting arrays #11271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
commented
Jun 11, 2024
Comment on lines
-391
to
+392
| public function castingHelper($field) | ||
| public function castingHelper($field, bool $useFallback = true) |
There was a problem hiding this comment.
Opted to add an extra param here instead of just never including defaults from this method because this reduces upgrade pains - any usage of this method outside of the obj() method should always fall back on the default casting.
GuySartorelli
commented
Jun 11, 2024
| @@ -559,15 +581,25 @@ public function obj($fieldName, $arguments = [], $cache = false, $cacheName = nu | |||
| $value = $this->$fieldName; | |||
| } | |||
|
|
|||
| // Try to cast object if we have an explicit cast set | |||
| if (!is_object($value)) { | |||
There was a problem hiding this comment.
Keeping this condition here (mirroring the below) because if a method returns an explicit object (usually DBField), the implication is that it shouldn't be re-cast.
We could choose to change that, but if so it should be handled in a separate card with an issue for that purpose.
This was referenced Jun 11, 2024
emteknetnz
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/symbiote/silverstripe-multivaluefield/actions/runs/9358332818/job/25759951695
This was caused by #11244 which didn't respect explicit pre-defined casting before casting arrays.
Needs silverstripe/silverstripe-cms#2960 for CI to be happy.
Issue