Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Remove GraphQL #11316

Merged
merged 1 commit into from
Sep 2, 2024
Merged

API Remove GraphQL #11316

merged 1 commit into from
Sep 2, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Jul 30, 2024
Closed
11 tasks
@emteknetnz emteknetnz marked this pull request as draft July 30, 2024 07:22
@emteknetnz emteknetnz force-pushed the pulls/6/remove-graphql branch 2 times, most recently from fd59a76 to 96ee562 Compare July 31, 2024 00:47
@emteknetnz emteknetnz force-pushed the pulls/6/remove-graphql branch from 96ee562 to b7880c5 Compare August 15, 2024 05:38
@emteknetnz emteknetnz marked this pull request as ready for review August 19, 2024 22:14
GuySartorelli
GuySartorelli requested changes Aug 20, 2024
View reviewed changes
src/Forms/FormRequestHandler.php Show resolved Hide resolved
src/ORM/Connect/NullDatabase.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/6/remove-graphql branch 2 times, most recently from 476c67d to c4d0751 Compare August 22, 2024 00:45
GuySartorelli
GuySartorelli approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when other PRs are happy

@emteknetnz emteknetnz force-pushed the pulls/6/remove-graphql branch 3 times, most recently from dd5d109 to d04c5f1 Compare August 28, 2024 02:07
GuySartorelli
GuySartorelli approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like aside from the rebase, the only change since last approval was the explicit addition of schemaDataType on GridField which seems like a sensible decision to me.

@emteknetnz emteknetnz force-pushed the pulls/6/remove-graphql branch from d04c5f1 to 2c8731d Compare August 30, 2024 00:06
GuySartorelli
GuySartorelli approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approved most recent changes

@GuySartorelli GuySartorelli merged commit 2b139b2 into silverstripe:6 Sep 2, 2024
11 of 12 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6/remove-graphql branch September 2, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli