Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX BASE_PATH fallback assumed wrong file location #9977

Merged
merged 1 commit into from
Jul 7, 2021
Merged

FIX BASE_PATH fallback assumed wrong file location #9977

merged 1 commit into from
Jul 7, 2021

Commits on Jun 9, 2021

  1. FIX BASE_PATH fallback assumed wrong file location 

    The file was moved back in 2017 with silverstripe@3873e4b#diff-8ce3f007bef0668c2c08320160362229abce9614025dc2a5b729d1b2b56ed3f7,
but the logic wasn't updated. That wasn't apparent since the fallback usually doesn't need to be triggered.
Whenever constants.php is included through the standard composer autoload, the debug_backtrace() logic took priority.

This is an important piece for using CoreKernel directly to boot Silverstripe,
which I'm currently attempting through a composer plugin (so a different autoloading path).
https://github.com/silverstripe/silverstripe-graphql-composer-plugin
    @chillu
    chillu committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    d2b7da2 View commit details
    Browse the repository at this point in the history