ENH Add generic types

silverstripe · Jan 11, 2024 · 13d9664 · 13d9664
1 parent 8226c4b
commit 13d9664
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/src/Control/LDAPDebugController.php b/src/Control/LDAPDebugController.php
@@ -18,6 +18,9 @@
  * Class LDAPDebugController
  *
  * This controller is used to debug the LDAP connection.
+ *
+ * @template T of SiteTree
+ * @extends ContentController<T>
  */
 class LDAPDebugController extends ContentController
 {

diff --git a/src/Extensions/LDAPGroupExtension.php b/src/Extensions/LDAPGroupExtension.php
@@ -15,7 +15,10 @@
  * Class LDAPGroupExtension
  *
  * Adds a field to map an LDAP group to a SilverStripe {@link Group}
+ *
  * @method SilverStripe\ORM\HasManyList<LDAPGroupMapping> LDAPGroupMappings()
+ *
+ * @extends DataExtension<Group&static>
  */
 class LDAPGroupExtension extends DataExtension
 {

diff --git a/src/Extensions/LDAPMemberExtension.php b/src/Extensions/LDAPMemberExtension.php
@@ -12,13 +12,14 @@
 use SilverStripe\ORM\DataExtension;
 use SilverStripe\ORM\ValidationException;
 use SilverStripe\ORM\ValidationResult;
+use SilverStripe\Security\Member;
 
 /**
  * Class LDAPMemberExtension.
  *
  * Adds mappings from AD attributes to SilverStripe {@link Member} fields.
  *
- * @package activedirectory
+ * @extends DataExtension<Member>
  */
 class LDAPMemberExtension extends DataExtension
 {