Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: PHP8 fix for removed ldap functions #95

Open
wants to merge 1 commit into
base: 2.2
Choose a base branch
from

Conversation

michalkouril
Copy link

Description

LDAP sync failing in PHP8 (per #56, #35) due to removal of ldap_control_paged_result. The fix is to use ldap_search in PHP8+ only.

Manual testing steps

Tested in AD environment.

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@forsdahl
Copy link

forsdahl commented Dec 2, 2024

Quickly looking at this PR, it seems it also includes another commit for adding nested_groups_search_locations and user_filter configs. Could you @michalkouril split those out to a separate PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants