ENH Add generic types #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuySartorelli
force-pushed
the
pulls/5/add-generics
branch
from
e6447ab to
d97baa1
Compare
emteknetnz
requested changes
Jan 18, 2024
src/Report/EnabledMembers.php
Outdated
| @@ -31,7 +31,7 @@ class EnabledMembers extends Report | |||
| * Cached registered methods fetched for the current list of members. This should only be populated at render time | |||
| * as methods will be fetched for the current "records" on the report | |||
| * | |||
| * @var DataList|null | |||
| * @var DataList<RegisteredMethod>|ArrayList<RegisteredMethod>|null | |||
There was a problem hiding this comment.
Suggested change
| * @var DataList<RegisteredMethod>|ArrayList<RegisteredMethod>|null | |
| * @var SS_List<RegisteredMethod>|null |
There was a problem hiding this comment.
Looks like it should actually be ArrayList<RegisteredMethod>|null so I'll change to that. I made a mistake when sight-reading getRegisteredMethodsForRecords() (which is the only place where it's set) before.
GuySartorelli
force-pushed
the
pulls/5/add-generics
branch
from
d97baa1 to
2394c21
Compare
emteknetnz
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires silverstripe/silverstripe-framework#11108 for these generics to take effect.
Issue