FIX Make sure the href attribute is constructed correctly when trailing slash is used

[edwilde]

Description

Just something I spotted in passing, when Controller::add_trailing_slash is enabled the href in the XML output for API responses is incorrect.

This adds a couple of tests, one to replicate the issue and fixes the issue.

The tests don't cover all usage as that would require setting up a proper stub etc. and I simply didn't have time for that. The fix should be fairly risk free.

Manual testing steps

• Enable trailing slashes: Controller::add_trailing_slash = true
• Request an API resource using the XML formatter
• See the href urls are constructed correctly and don't end in /.xml

Issues

• When trailing slash is used the XML href attribute is set incorrectly #138

Pull request checklist

• The target branch is correct
  • See picking the right version
• All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
  • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
• The commit messages follow our commit message guidelines
• The PR follows our contribution guidelines
• Code changes follow our coding conventions
• This change is covered with tests (or tests aren't necessary for this change)
• Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
• CI is green

[emteknetnz]

These two tests are basically identical, use a single test and use a @dataProvider and a bool $trailingSlash param.

[edwilde]

Yep, I was being lazy 😪

[emteknetnz]

Sorry should have asked to target 3.0 so that it can be patched released immediately. You may need to rebase