ENH Add generic types

silverstripe · Jan 11, 2024 · 967d99d · 967d99d
1 parent c1c6be9
commit 967d99d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 1 deletion.
diff --git a/src/Extensions/MemberExtension.php b/src/Extensions/MemberExtension.php
@@ -10,7 +10,10 @@
 
 /**
  * Augment `Member` to allow relationship to the LoginSession DataObject
+ *
  * @method SilverStripe\ORM\HasManyList<LoginSession> LoginSessions()
+ *
+ * @extends DataExtension<Member>
  */
 class MemberExtension extends DataExtension
 {

diff --git a/src/Extensions/QueuedJobDescriptorExtension.php b/src/Extensions/QueuedJobDescriptorExtension.php
@@ -4,7 +4,11 @@
 
 use SilverStripe\Core\Extension;
 use SilverStripe\SessionManager\Jobs\GarbageCollectionJob;
+use Symbiote\QueuedJobs\DataObjects\QueuedJobDescriptor;
 
+/**
+ * @extends Extension<QueuedJobDescriptor>
+ */
 class QueuedJobDescriptorExtension extends Extension
 {
     /**

diff --git a/src/Extensions/RememberLoginHashExtension.php b/src/Extensions/RememberLoginHashExtension.php
@@ -5,11 +5,14 @@
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Core\Extension;
 use SilverStripe\Core\Injector\Injector;
+use SilverStripe\Security\RememberLoginHash;
 use SilverStripe\SessionManager\Models\LoginSession;
 use SilverStripe\SessionManager\Security\LogInAuthenticationHandler;
 
 /**
  * @method LoginSession LoginSession()
+ *
+ * @extends Extension<RememberLoginHash>
  */
 class RememberLoginHashExtension extends Extension
 {

diff --git a/src/Models/LoginSession.php b/src/Models/LoginSession.php
@@ -292,7 +292,7 @@ public function isCurrent(?HTTPRequest $request = null): bool
 
     /**
      * @param Member $member
-     * @return DataList|LoginSession[]
+     * @return DataList<LoginSession>
      */
     public static function getCurrentSessions(Member $member)
     {