Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed two out-of-date translation strings #115

Closed
wants to merge 1 commit into from
Closed

Removed two out-of-date translation strings #115

wants to merge 1 commit into from

Conversation

micschk
Copy link

@micschk micschk commented Jul 11, 2022

Strings don't seem to be used in LoginSessionController anymore.
Other empty strings have all been filled so #114 can probably be closed.

@micschk
Removed two out-of-date translation strings
5513c45 
Strings don't seem to be used in LoginSessionController anymore.
Other empty strings have all been filled so silverstripe#114 can probably be closed.
@GuySartorelli
Copy link
Member

GuySartorelli commented Aug 8, 2022 •
edited
Loading

Thanks for this.
We manage translation strings through transifex rather than in github directly. We also don't remove outdated translation strings because this has in the past had a flow-back effect that causes older versions to have missing translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@micschk @GuySartorelli