Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Remove GraphQL #584

Merged
merged 1 commit into from
Sep 2, 2024
Merged

API Remove GraphQL #584

merged 1 commit into from
Sep 2, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Jul 30, 2024
Closed
11 tasks
@emteknetnz emteknetnz marked this pull request as draft July 30, 2024 07:35
@emteknetnz emteknetnz force-pushed the pulls/4/remove-graphql branch from abb4101 to 4a090f0 Compare July 31, 2024 00:24
@emteknetnz emteknetnz force-pushed the pulls/4/remove-graphql branch from 4a090f0 to 5931ff4 Compare August 7, 2024 04:09
@emteknetnz emteknetnz force-pushed the pulls/4/remove-graphql branch from 5931ff4 to 4d29c7f Compare August 7, 2024 04:42
@emteknetnz emteknetnz force-pushed the pulls/4/remove-graphql branch 3 times, most recently from c26c18d to cd15e37 Compare August 15, 2024 05:39
@emteknetnz emteknetnz marked this pull request as ready for review August 19, 2024 22:14
GuySartorelli
GuySartorelli requested changes Aug 20, 2024
View reviewed changes
tests/behat/features/operate-subsites.feature Outdated Show resolved Hide resolved
tests/behat/features/operate-subsites.feature Outdated Show resolved Hide resolved
tests/behat/features/operate-subsites.feature Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/4/remove-graphql branch from cd15e37 to c215b4c Compare August 22, 2024 00:50
@emteknetnz emteknetnz force-pushed the pulls/4/remove-graphql branch from c215b4c to 4333d36 Compare August 22, 2024 08:21
GuySartorelli
GuySartorelli requested changes Aug 23, 2024
View reviewed changes
tests/behat/features/operate-subsites.feature Outdated Show resolved Hide resolved
tests/behat/features/operate-subsites.feature Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/4/remove-graphql branch from 4333d36 to d0626e2 Compare August 23, 2024 08:11
@emteknetnz
Copy link
Member Author

Have reverted

@emteknetnz emteknetnz force-pushed the pulls/4/remove-graphql branch from d0626e2 to 50fb7f8 Compare August 27, 2024 03:45
GuySartorelli
GuySartorelli requested changes Aug 29, 2024
View reviewed changes
tests/behat/features/operate-subsites.feature Outdated Show resolved Hide resolved
tests/behat/features/operate-subsites.feature Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/4/remove-graphql branch from 50fb7f8 to 2206489 Compare August 29, 2024 00:57
@emteknetnz emteknetnz force-pushed the pulls/4/remove-graphql branch from 2206489 to 83f3d9e Compare August 30, 2024 00:07
GuySartorelli
GuySartorelli approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit bd3edce into silverstripe:4 Sep 2, 2024
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/4/remove-graphql branch September 2, 2024 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NightJar NightJar NightJar left review comments

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emteknetnz @NightJar @GuySartorelli