FIX Avoid infinite recursive loop with attributes in schemadata

silverstripe · Nov 15, 2024 · d6bc04c · d6bc04c
1 parent 656598a
commit d6bc04c
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 15 deletions.
diff --git a/src/StringTagField.php b/src/StringTagField.php
@@ -197,19 +197,6 @@ protected function formatOptions($fieldValue)
         return $formattedValue;
     }
 
-    /**
-     * When not used in a React form factory context, this adds the schema data to SilverStripe template
-     * rendered attributes lists
-     *
-     * @return array
-     */
-    public function getAttributes()
-    {
-        $attributes = parent::getAttributes();
-        $attributes['data-schema'] = json_encode($this->getSchemaData());
-        return $attributes;
-    }
-
     /**
      * @return string
      */

diff --git a/src/TagField.php b/src/TagField.php
@@ -381,7 +381,6 @@ public function getAttributes()
             [
                 'name' => $name,
                 'style' => 'width: 100%',
-                'data-schema' => json_encode($this->getSchemaData()),
             ]
         );
     }

diff --git a/templates/SilverStripe/TagField/TagField.ss b/templates/SilverStripe/TagField/TagField.ss
@@ -1 +1 @@
-<div $AttributesHTML></div>
+<div $AttributesHTML data-schema="$SchemaData.JSON"></div>
-Original file line number
+Diff line change
@@ Expand Up / @@ -381,7 +381,6 @@ public function getAttributes() @@
                 [
                     'name' => $name,
                     'style' => 'width: 100%',
-                    'data-schema' => json_encode($this->getSchemaData()),
                 ]
             );
         }
@@ Expand Down @@
Original file line number	Diff line number	Diff line change
		@@ -1 +1 @@
		<div $AttributesHTML></div>
		<div $AttributesHTML data-schema="$SchemaData.JSON"></div>