Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Rewrite front-end JS in vanilla JS #1197

Open
wants to merge 15 commits into
base: 5
Choose a base branch
from

Conversation

fonsekaean
Copy link
Contributor

This removed the requirement of jQuery on front end validations, display rules and step navigations.

@michalkleiner michalkleiner changed the title Feature/vanila js front end ENH Rewrite front-end JS in vanilla JS Mar 21, 2023
@michalkleiner
Copy link
Contributor

Interesting start, keen to see results of the tests. It's also quite hard to read the JS file diff since everything changed.

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume based on the failed tests that this isn't ready yet - should this be a draft?

client/dist/js/userforms-cms.js.map Outdated Show resolved Hide resolved
@michalkleiner
Copy link
Contributor

I assume based on the failed tests that this isn't ready yet - should this be a draft?

@GuySartorelli for some modules tests are failing on composer install, it can't get some core dependencies. Similar for e.g. contentreview module. It's not a functional issue, it doesn't even get to testing that.

@GuySartorelli
Copy link
Member

Ahh, I didn't even think to click through to see if the failures were something like that 😅

@GuySartorelli
Copy link
Member

GuySartorelli commented Apr 4, 2023

@fonsekaean Just to be clear, as I see you're occasionally making new commits to this - is this still a work in progress, or is it ready for review?
If it's still a work in progress, please mark it as a draft.

@fonsekaean
Copy link
Contributor Author

@GuySartorelli its all done, I was testing it on a project and found a specific issue that I sorted.

@fonsekaean
Copy link
Contributor Author

did another commit and that should be the last one @GuySartorelli

@michalkleiner
Copy link
Contributor

And another one.. I reckon we probably need a wider testing/more experience with the change before we accept the PR.

@michalkleiner
Copy link
Contributor

The pagination and progress title failing tests seem relevant.

@fonsekaean
Copy link
Contributor Author

I will check that one out. Also did some slight updates today as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants